netdev - Re: [PATCH V2] ethernet: Fix some formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220407193828.6c95928c@kernel.org>
Date:   Thu, 7 Apr 2022 19:38:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] ethernet: Fix some formatting issues

On Thu, 7 Apr 2022 18:36:04 +0800 Haowen Bai wrote:
> reported by checkpatch.pl

Please don't send "checkpatch fixes" for networking.

> WARNING: suspect code indent for conditional statements (16, 16)
> #732: FILE: drivers/net/ethernet/3com/3c589_cs.c:732:
> CHECK: Alignment should match open parenthesis
> #733: FILE: drivers/net/ethernet/3com/3c589_cs.c:733:
> CHECK: Alignment should match open parenthesis
> #735: FILE: drivers/net/ethernet/3com/3c589_cs.c:735:
> WARNING: suspect code indent for conditional statements (16, 16)
> #736: FILE: drivers/net/ethernet/3com/3c589_cs.c:736:
> CHECK: Alignment should match open parenthesis
> #737: FILE: drivers/net/ethernet/3com/3c589_cs.c:737:
> CHECK: Alignment should match open parenthesis
> #739: FILE: drivers/net/ethernet/3com/3c589_cs.c:739:
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>