netdev - Re: [EXT] [PATCH v2] net: atlantic: Avoid out-of-bounds indexing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 16:38:58 +0200
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>, <davem@...emloft.net>,
        <kuba@...nel.org>
CC:     Mario Limonciello <mario.limonciello@....com>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH v2] net: atlantic: Avoid out-of-bounds indexing



> UBSAN warnings are observed on atlantic driver:
> [ 294.432996] UBSAN: array-index-out-of-bounds in
> /build/linux-Qow4fL/linux-5.15.0/drivers/net/ethernet/aquantia/atlantic/aq
> _nic.c:484:48
> [ 294.433695] index 8 is out of range for type 'aq_vec_s *[8]'
> 
> The ring is dereferenced right before breaking out the loop, to prevent
> that from happening, only use the index in the loop to fix the issue.

Thanks,

Reviewed-by: Igor Russkikh <irusskikh@...vell.com>

Igor