netdev - Re: [PATCH v2] RDMA: Split kernel-only global device caps from uverbs device caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220408164554.GA3613777@nvidia.com>
Date:   Fri, 8 Apr 2022 13:45:54 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Ariel Elior <aelior@...vell.com>, Anna Schumaker <anna@...nel.org>,
        Jens Axboe <axboe@...com>,
        Christian Benvenuti <benve@...co.com>,
        Potnuri Bharat Teja <bharat@...lsio.com>,
        Bernard Metzler <bmt@...ich.ibm.com>,
        Bart Van Assche <bvanassche@....org>,
        Chuck Lever <chuck.lever@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Christoph Hellwig <hch@....de>,
        Keith Busch <kbusch@...nel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leon@...nel.org>, linux-cifs@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-rdma@...r.kernel.org, Max Gurtovoy <mgurtovoy@...dia.com>,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        Mustafa Ismail <mustafa.ismail@...el.com>,
        Nelson Escobar <neescoba@...co.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>, rds-devel@....oracle.com,
        Sagi Grimberg <sagi@...mberg.me>,
        samba-technical@...ts.samba.org,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Steve French <sfrench@...ba.org>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        target-devel@...r.kernel.org,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Zhu Yanjun <zyjzyj2000@...il.com>
Subject: Re: [PATCH v2] RDMA: Split kernel-only global device caps from
 uverbs device caps

On Wed, Apr 06, 2022 at 04:27:18PM -0300, Jason Gunthorpe wrote:
> Split out flags from ib_device::device_cap_flags that are only used
> internally to the kernel into kernel_cap_flags that is not part of the
> uapi. This limits the device_cap_flags to being only flags exposed by the
> driver toward userspace.
> 
> This cleanly splits out the uverbs flags from the kernel flags to avoid
> confusion in the flags bitmap.
> 
> Add some short comments describing which each of the kernel flags is
> connected to. Remove unused kernel flags.
> 
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
>  drivers/infiniband/core/nldev.c              |  2 +-
>  drivers/infiniband/core/uverbs_cmd.c         |  6 +-
>  drivers/infiniband/core/verbs.c              |  8 +-
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c     |  2 +-
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h       |  1 -
>  drivers/infiniband/hw/cxgb4/provider.c       |  8 +-
>  drivers/infiniband/hw/hfi1/verbs.c           |  4 +-
>  drivers/infiniband/hw/irdma/hw.c             |  4 -
>  drivers/infiniband/hw/irdma/main.h           |  1 -
>  drivers/infiniband/hw/irdma/verbs.c          |  4 +-
>  drivers/infiniband/hw/mlx4/main.c            |  8 +-
>  drivers/infiniband/hw/mlx5/main.c            | 15 ++--
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  |  2 +-
>  drivers/infiniband/hw/qedr/verbs.c           |  3 +-
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c |  3 +-
>  drivers/infiniband/sw/rxe/rxe.c              |  1 +
>  drivers/infiniband/sw/rxe/rxe_param.h        |  1 -
>  drivers/infiniband/sw/siw/siw_verbs.c        |  4 +-
>  drivers/infiniband/ulp/ipoib/ipoib.h         |  1 +
>  drivers/infiniband/ulp/ipoib/ipoib_main.c    |  5 +-
>  drivers/infiniband/ulp/ipoib/ipoib_verbs.c   |  6 +-
>  drivers/infiniband/ulp/iser/iscsi_iser.c     |  2 +-
>  drivers/infiniband/ulp/iser/iser_verbs.c     |  8 +-
>  drivers/infiniband/ulp/isert/ib_isert.c      |  2 +-
>  drivers/infiniband/ulp/srp/ib_srp.c          |  8 +-
>  drivers/nvme/host/rdma.c                     |  4 +-
>  drivers/nvme/target/rdma.c                   |  4 +-
>  fs/cifs/smbdirect.c                          |  2 +-
>  include/rdma/ib_verbs.h                      | 84 ++++++++------------
>  include/rdma/opa_vnic.h                      |  3 +-
>  include/uapi/rdma/ib_user_verbs.h            |  4 +
>  net/rds/ib.c                                 |  4 +-
>  net/sunrpc/xprtrdma/frwr_ops.c               |  2 +-
>  33 files changed, 100 insertions(+), 116 deletions(-)
> 
> v2:
>  - Use IBK_ as the flag prefix for brevity
>  - Remove unneeded ULLs
>  - Spelling
>  - Short documentation for each of the kernel flags

Applied to for-next, thanks everyone

Jason