[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220409095533.GB19371@breakpoint.cc>
Date: Sat, 9 Apr 2022 11:55:33 +0200
From: Florian Westphal <fw@...len.de>
To: Mark Mielke <mark.mielke@...il.com>
Cc: netdev@...r.kernel.org, dev@...nvswitch.org,
Pravin B Shelar <pshelar@....org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH] openvswitch: Ensure nf_ct_put is not called with null
pointer
Mark Mielke <mark.mielke@...il.com> wrote:
> A recent commit replaced calls to nf_conntrack_put() with calls
> to nf_ct_put(). nf_conntrack_put() permitted the caller to pass
> null without side effects, while nf_ct_put() performs WARN_ON()
> and proceeds to try and de-reference the pointer. ovs-vswitchd
> triggers the warning on startup:
>
> [ 22.178881] WARNING: CPU: 69 PID: 2157 at include/net/netfilter/nf_conntrack.h:176 __ovs_ct_lookup+0x4e2/0x6a0 [openvswitch]
> ...
> [ 22.213573] Call Trace:
> [ 22.214318] <TASK>
> [ 22.215064] ovs_ct_execute+0x49c/0x7f0 [openvswitch]
Applied to nf.git, thanks.
Powered by blists - more mailing lists