lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Apr 2022 10:20:27 -0700 From: Joe Damato <jdamato@...tly.com> To: Lorenzo Bianconi <lorenzo@...nel.org> Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, jbrouer@...hat.com, ilias.apalodimas@...aro.org Subject: Re: [PATCH net-next] page_pool: Add recycle stats to page_pool_put_page_bulk On Tue, Apr 05, 2022 at 10:52:55PM +0200, Lorenzo Bianconi wrote: > Add missing recycle stats to page_pool_put_page_bulk routine. > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> > --- > net/core/page_pool.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 1943c0f0307d..4af55d28ffa3 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -36,6 +36,12 @@ > this_cpu_inc(s->__stat); \ > } while (0) > > +#define recycle_stat_add(pool, __stat, val) \ > + do { \ > + struct page_pool_recycle_stats __percpu *s = pool->recycle_stats; \ > + this_cpu_add(s->__stat, val); \ > + } while (0) > + > bool page_pool_get_stats(struct page_pool *pool, > struct page_pool_stats *stats) > { > @@ -63,6 +69,7 @@ EXPORT_SYMBOL(page_pool_get_stats); > #else > #define alloc_stat_inc(pool, __stat) > #define recycle_stat_inc(pool, __stat) > +#define recycle_stat_add(pool, __stat, val) > #endif > > static int page_pool_init(struct page_pool *pool, > @@ -566,9 +573,13 @@ void page_pool_put_page_bulk(struct page_pool *pool, void **data, > /* Bulk producer into ptr_ring page_pool cache */ > page_pool_ring_lock(pool); > for (i = 0; i < bulk_len; i++) { > - if (__ptr_ring_produce(&pool->ring, data[i])) > - break; /* ring full */ > + if (__ptr_ring_produce(&pool->ring, data[i])) { > + /* ring full */ > + recycle_stat_inc(pool, ring_full); > + break; > + } > } > + recycle_stat_add(pool, ring, i); > page_pool_ring_unlock(pool); > > /* Hopefully all pages was return into ptr_ring */ > -- > 2.35.1 > Thanks for doing this! Reviewed-by: Joe Damato <jdamato@...tly.com>
Powered by blists - more mailing lists