netdev - Re: [PATCH net-next v2] net: remove noblock parameter from recvmsg() entities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 11 Apr 2022 07:13:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH net-next v2] net: remove noblock parameter from recvmsg()
 entities

Hi Oliver,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-040924
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 516a2f1f6f3ce1a87931579cc21de6e7e33440bd
config: x86_64-randconfig-a004-20220411 (https://download.01.org/0day-ci/archive/20220411/202204110751.725yvW2W-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 256c6b0ba14e8a7ab6373b61b7193ea8c0a3651c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8c4751aaa17d68be940bdaf4bb1402d1a34a60e7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-040924
        git checkout 8c4751aaa17d68be940bdaf4bb1402d1a34a60e7
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/dccp/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/dccp/ipv4.c:959:14: error: incompatible function pointer types initializing 'int (*)(struct sock *, struct msghdr *, size_t, int, int *)' (aka 'int (*)(struct sock *, struct msghdr *, unsigned long, int, int *)') with an expression of type 'int (struct sock *, struct msghdr *, size_t, int, int, int *)' (aka 'int (struct sock *, struct msghdr *, unsigned long, int, int, int *)') [-Werror,-Wincompatible-function-pointer-types]
           .recvmsg                = dccp_recvmsg,
                                     ^~~~~~~~~~~~
   1 error generated.
--
>> net/dccp/ipv6.c:1044:16: error: incompatible function pointer types initializing 'int (*)(struct sock *, struct msghdr *, size_t, int, int *)' (aka 'int (*)(struct sock *, struct msghdr *, unsigned long, int, int *)') with an expression of type 'int (struct sock *, struct msghdr *, size_t, int, int, int *)' (aka 'int (struct sock *, struct msghdr *, unsigned long, int, int, int *)') [-Werror,-Wincompatible-function-pointer-types]
           .recvmsg           = dccp_recvmsg,
                                ^~~~~~~~~~~~
   1 error generated.


vim +959 net/dccp/ipv4.c

6d6ee43e0b8b8d Arnaldo Carvalho de Melo 2005-12-13  947  
5e0817f84c3328 Adrian Bunk              2006-03-20  948  static struct proto dccp_v4_prot = {
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  949  	.name			= "DCCP",
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  950  	.owner			= THIS_MODULE,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  951  	.close			= dccp_close,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  952  	.connect		= dccp_v4_connect,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  953  	.disconnect		= dccp_disconnect,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  954  	.ioctl			= dccp_ioctl,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  955  	.init			= dccp_v4_init_sock,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  956  	.setsockopt		= dccp_setsockopt,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  957  	.getsockopt		= dccp_getsockopt,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  958  	.sendmsg		= dccp_sendmsg,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09 @959  	.recvmsg		= dccp_recvmsg,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  960  	.backlog_rcv		= dccp_v4_do_rcv,
ab1e0a13d70299 Arnaldo Carvalho de Melo 2008-02-03  961  	.hash			= inet_hash,
ab1e0a13d70299 Arnaldo Carvalho de Melo 2008-02-03  962  	.unhash			= inet_unhash,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  963  	.accept			= inet_csk_accept,
ab1e0a13d70299 Arnaldo Carvalho de Melo 2008-02-03  964  	.get_port		= inet_csk_get_port,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  965  	.shutdown		= dccp_shutdown,
3e0fadc51f2fde Arnaldo Carvalho de Melo 2006-03-20  966  	.destroy		= dccp_destroy_sock,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  967  	.orphan_count		= &dccp_orphan_count,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  968  	.max_header		= MAX_DCCP_HEADER,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  969  	.obj_size		= sizeof(struct dccp_sock),
5f0d5a3ae7cff0 Paul E. McKenney         2017-01-18  970  	.slab_flags		= SLAB_TYPESAFE_BY_RCU,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  971  	.rsk_prot		= &dccp_request_sock_ops,
6d6ee43e0b8b8d Arnaldo Carvalho de Melo 2005-12-13  972  	.twsk_prot		= &dccp_timewait_sock_ops,
39d8cda76cfb11 Pavel Emelyanov          2008-03-22  973  	.h.hashinfo		= &dccp_hashinfo,
7c657876b63cb1 Arnaldo Carvalho de Melo 2005-08-09  974  };
6d6ee43e0b8b8d Arnaldo Carvalho de Melo 2005-12-13  975  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp