netdev - Re: [PATCH v2 net-next] page_pool: Add recycle stats to page_pool_put_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 17:21:33 +0300
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        jbrouer@...hat.com, jdamato@...tly.com
Subject: Re: [PATCH v2 net-next] page_pool: Add recycle stats to page_pool_put_page_bulk

On Mon, 11 Apr 2022 at 17:05, Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Add missing recycle stats to page_pool_put_page_bulk routine.
>
> Reviewed-by: Joe Damato <jdamato@...tly.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
> Changes since v1:
> - rebase on net-next
> ---
>  net/core/page_pool.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 1943c0f0307d..4af55d28ffa3 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -36,6 +36,12 @@
>                 this_cpu_inc(s->__stat);                                                \
>         } while (0)
>
> +#define recycle_stat_add(pool, __stat, val)                                            \
> +       do {                                                                            \
> +               struct page_pool_recycle_stats __percpu *s = pool->recycle_stats;       \
> +               this_cpu_add(s->__stat, val);                                           \
> +       } while (0)
> +
>  bool page_pool_get_stats(struct page_pool *pool,
>                          struct page_pool_stats *stats)
>  {
> @@ -63,6 +69,7 @@ EXPORT_SYMBOL(page_pool_get_stats);
>  #else
>  #define alloc_stat_inc(pool, __stat)
>  #define recycle_stat_inc(pool, __stat)
> +#define recycle_stat_add(pool, __stat, val)
>  #endif
>
>  static int page_pool_init(struct page_pool *pool,
> @@ -566,9 +573,13 @@ void page_pool_put_page_bulk(struct page_pool *pool, void **data,
>         /* Bulk producer into ptr_ring page_pool cache */
>         page_pool_ring_lock(pool);
>         for (i = 0; i < bulk_len; i++) {
> -               if (__ptr_ring_produce(&pool->ring, data[i]))
> -                       break; /* ring full */
> +               if (__ptr_ring_produce(&pool->ring, data[i])) {
> +                       /* ring full */
> +                       recycle_stat_inc(pool, ring_full);
> +                       break;
> +               }
>         }
> +       recycle_stat_add(pool, ring, i);
>         page_pool_ring_unlock(pool);
>
>         /* Hopefully all pages was return into ptr_ring */
> --
> 2.35.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>