netdev - Re: [Linux 5.18-rc1] WARNING: possible circular locking dependency detected at (rtw_ops_config, ieee80211_mgd_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <446ea9872d46fe0ad594cfa6d3df224cfcb5223f.camel@sipsolutions.net>
Date:   Mon, 11 Apr 2022 16:46:47 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Ammar Faizi <ammarfaizi2@...weeb.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Linux Wireless Mailing List <linux-wireless@...r.kernel.org>,
        netdev Mailing List <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Yan-Hsuan Chuang <tony0620emma@...il.com>
Subject: Re: [Linux 5.18-rc1] WARNING: possible circular locking dependency
 detected at (rtw_ops_config, ieee80211_mgd_probe_ap)

On Thu, 2022-04-07 at 08:26 +0700, Ammar Faizi wrote:
> 
> [21860.955836]  Possible unsafe locking scenario:
> 
> [21860.955837]        CPU0                    CPU1
> [21860.955837]        ----                    ----
> [21860.955838]   lock(&local->iflist_mtx);
> [21860.955839]                                lock(&rtwdev->mutex);
> [21860.955840]                                lock(&local->iflist_mtx);
> [21860.955841]   lock(&rtwdev->mutex);
> [21860.955842]
>                   *** DEADLOCK ***
> 

The driver needs to fix this, cannot call ieee80211_iterate_interfaces()
inside a section locked this way. I _think_ this deadlock used to be
documented by it looks like that documentation got moved around or
something.

johannes