lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Apr 2022 18:11:14 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Pavel Skripkin <paskripkin@...il.com> Cc: David Kahurani <k.kahurani@...il.com>, netdev <netdev@...r.kernel.org>, syzbot+d3dbdf31fbe9d8f5f311@...kaller.appspotmail.com, "David S. Miller" <davem@...emloft.net>, Jason Gunthorpe <jgg@...pe.ca>, Jakub Kicinski <kuba@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, USB <linux-usb@...r.kernel.org>, Phillip Potter <phil@...lpotter.co.uk>, syzkaller-bugs <syzkaller-bugs@...glegroups.com>, Arnd Bergmann <arnd@...db.de> Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read errors On Tue, Apr 5, 2022 at 3:05 AM Pavel Skripkin <paskripkin@...il.com> wrote: > On 4/4/22 18:10, David Kahurani wrote: > > Reads that are lesser than the requested size lead to uninit-value bugs. Qualify > > such reads as errors and handle them correctly. > I'd personally cut this log a bit and would add this part of the initial > report > > Local variable eeprom.i created at: > ax88179_check_eeprom drivers/net/usb/ax88179_178a.c:1045 [inline] > ax88179_led_setting+0x2e2/0x30b0 drivers/net/usb/ax88179_178a.c:1168 > ax88179_bind+0xe75/0x1990 drivers/net/usb/ax88179_178a.c:1411 > > Since it shows exactly where problem comes from. > > I do not insist, just IMO I insist though. It will reduce the resource consumption (i.e. storage and network load on cloning / pulling) a lot (taking into account multiplier of how many Linux kernel source copies are around the globe) and hence become more environmentally friendly. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists