netdev - Re: [PATCH mlx5-next 02/17] net/mlx5: Check IPsec TX flow steering namespace in advance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YlPIz5LA9zO0H4rA@unreal>
Date:   Mon, 11 Apr 2022 09:21:03 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Saeed Mahameed <saeedm@...dia.com>
Cc:     Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jason Gunthorpe <jgg@...dia.com>,
        linux-netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Raed Salem <raeds@...dia.com>
Subject: Re: [PATCH mlx5-next 02/17] net/mlx5: Check IPsec TX flow steering
 namespace in advance

On Sun, Apr 10, 2022 at 04:46:12PM -0700, Saeed Mahameed wrote:
> On 10 Apr 11:28, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@...dia.com>
> > 
> > Ensure that flow steering is usable as early as possible, to understand
> > if crypto IPsec is supported or not.
> > 
> > Reviewed-by: Raed Salem <raeds@...dia.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en/fs.h  |  1 -
> > .../ethernet/mellanox/mlx5/core/en_accel/ipsec.c |  1 +
> > .../ethernet/mellanox/mlx5/core/en_accel/ipsec.h |  1 +
> > .../mellanox/mlx5/core/en_accel/ipsec_fs.c       | 16 +++++++++-------
> > 4 files changed, 11 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
> > index 678ffbb48a25..4130a871de61 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h
> > @@ -164,7 +164,6 @@ struct mlx5e_ptp_fs;
> > 
> > struct mlx5e_flow_steering {
> > 	struct mlx5_flow_namespace      *ns;
> > -	struct mlx5_flow_namespace      *egress_ns;
> > #ifdef CONFIG_MLX5_EN_RXNFC
> > 	struct mlx5e_ethtool_steering   ethtool;
> > #endif
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > index 5a10755dd4f1..285ccb773de6 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c
> > @@ -415,6 +415,7 @@ int mlx5e_ipsec_init(struct mlx5e_priv *priv)
> > 
> > 	hash_init(ipsec->sadb_rx);
> > 	spin_lock_init(&ipsec->sadb_rx_lock);
> > +	ipsec->mdev = priv->mdev;
> > 	ipsec->en_priv = priv;
> > 	ipsec->wq = alloc_ordered_workqueue("mlx5e_ipsec: %s", 0,
> > 					    priv->netdev->name);
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
> > index a0e9dade09e9..bbf48d4616f9 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h
> > @@ -61,6 +61,7 @@ struct mlx5e_accel_fs_esp;
> > struct mlx5e_ipsec_tx;
> > 
> > struct mlx5e_ipsec {
> > +	struct mlx5_core_dev *mdev;
> > 	struct mlx5e_priv *en_priv;
> 
> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>
> 
> we could probably remove en_priv, I already sent you a patch, please try to
> include it in the next version.

I removed this en_priv in patch #6 "net/mlx5: Store IPsec ESN update work in XFRM state"
https://lore.kernel.org/netdev/1d965d2697dda0bd2c34fc1ccbbb45efaf03b0de.1649578827.git.leonro@nvidia.com/T/#u

Thanks