netdev - Re: [PATCH RFC net-next 09/13] selftests: forwarding: rename test groups for next bridge mdb tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220411202315.mxgqmvktodavdmwr@skbuf>
Date:   Mon, 11 Apr 2022 20:23:15 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Joachim Wiberg <troglobit@...il.com>
CC:     Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [PATCH RFC net-next 09/13] selftests: forwarding: rename test
 groups for next bridge mdb tests

On Mon, Apr 11, 2022 at 03:38:33PM +0200, Joachim Wiberg wrote:
> Rename test groups to PASS and FAIL, respectively, for upcoming changes
> to test suite.
> 
> Signed-off-by: Joachim Wiberg <troglobit@...il.com>
> ---
>  .../selftests/net/forwarding/bridge_mdb.sh     | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> index b1ba6876dd86..c0b84b7d4364 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_mdb.sh
> @@ -7,9 +7,15 @@
>  ALL_TESTS="mdb_add_del_test"
>  NUM_NETIFS=2
>  
> -TEST_GROUP_IP4="225.1.2.3"
> -TEST_GROUP_IP6="ff02::42"
> -TEST_GROUP_MAC="01:00:01:c0:ff:ee"
> +PASS_GRP_IP4="225.1.2.3"
> +FAIL_GRP_IP4="225.1.2.4"

This is more than just the advertised rename, the fail groups are new
and not used in this change.

> +
> +PASS_GRP_MAC="01:00:01:c0:ff:ee"
> +FAIL_GRP_MAC="01:00:01:c0:ff:ef"
> +
> +PASS_GRP_IP6="ff02::42"
> +FAIL_GRP_IP6="ff02::43"
> +
>  
>  source lib.sh
>  
> @@ -88,9 +94,9 @@ do_mdb_add_del()
>  
>  mdb_add_del_test()
>  {
> -	do_mdb_add_del $TEST_GROUP_MAC permanent
> -	do_mdb_add_del $TEST_GROUP_IP4
> -	do_mdb_add_del $TEST_GROUP_IP6
> +	do_mdb_add_del $PASS_GRP_MAC permanent
> +	do_mdb_add_del $PASS_GRP_IP4
> +	do_mdb_add_del $PASS_GRP_IP6
>  }
>  
>  trap cleanup EXIT
> -- 
> 2.25.1
>