netdev - Re: [PATCH net-next 0/5] flower: match on the number of vlan tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24581ebb-e952-d1d8-8d64-a51c94e29bc8@mojatatu.com>
Date:   Tue, 12 Apr 2022 06:54:43 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Boris Sukholitko <boris.sukholitko@...adcom.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        zhang kai <zhangkaiheb@....com>,
        Yoshiki Komachi <komachi.yoshiki@...il.com>,
        Ilya Lifshits <ilya.lifshits@...adcom.com>
Subject: Re: [PATCH net-next 0/5] flower: match on the number of vlan tags

On 2022-04-11 10:56, Boris Sukholitko wrote:
> On Mon, Apr 11, 2022 at 10:07:14AM -0400, Jamal Hadi Salim wrote:
>> On 2022-04-11 09:30, Boris Sukholitko wrote:
>>> Hi,

[..]

>> Can you please provide more elaborate example of more than 1 vlan?
> 
> Perusing our logs, we have redirect rules such as:
> 
> tc filter add dev $GPON ingress flower num_of_vlans $N \
>     action mirred egress redirect dev $DEV
>

Please add in the commit logs.

> where N can range from 0 to 3 and $DEV is the function of $N.
> 

Also in the commit log, very specific to GPON. I have seen upto
4 in some telco environment.

> Also there are rules setting skb mark based on the number of vlans:
> 
> tc filter add dev $GPON ingress flower num_of_vlans $N vlan_prio \
>     $P action skbedit mark $M
>

Yep makes sense.


>> Where would the line be drawn:
>> Is it max of two vlans?
> 
> We have seen the maximum of 3 vlans.
> 
>> Is there potential of <=X, meaning matching of upto X Vlans?
>>
> 
> We've managed to get by without such feature somehow :)

If needed should be extensible. You already have ability to count, so
adding inequality check should not be hard to add when needed.

cheers,
jamal