lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YlVd79bM00wuK9yW@nanopsycho> Date: Tue, 12 Apr 2022 13:09:35 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Boris Sukholitko <boris.sukholitko@...adcom.com> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, "Gustavo A . R . Silva" <gustavoars@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Eric Dumazet <edumazet@...gle.com>, zhang kai <zhangkaiheb@....com>, Yoshiki Komachi <komachi.yoshiki@...il.com>, Ilya Lifshits <ilya.lifshits@...adcom.com> Subject: Re: [PATCH net-next v2 5/5] net/sched: flower: Consider the number of tags for vlan filters Tue, Apr 12, 2022 at 12:02:36PM CEST, boris.sukholitko@...adcom.com wrote: >Currently the existence of vlan filters is conditional on the vlan >protocol being matched in the tc rule. I.e. the following rule: > >tc filter add dev eth1 ingress flower vlan_prio 5 > >is illegal because we lack protocol 802.1q in the rule. > >Having the num_of_vlans filter configured removes this restriction. The >following rule becomes ok: > >tc filter add dev eth1 ingress flower num_of_vlans 1 vlan_prio 5 > >because we know that the packet is single tagged. > >We achieve the above by having is_vlan_key helper look at the number of Sorry to be a nitpicker, but who's "we"? When I read the patch description, I need to understand clearly what the patch is doing, which is not this case. You suppose to command the codebase what to do. I fail to see that :/ >vlans in addition to the vlan ethertype. Outer tag vlan filters (e.g. >vlan_prio) require the number of vlan tags be greater than 0. Inner >filters (e.g. cvlan_prio) require the number of vlan tags be greater >than 1. > >Number of vlans filter may cause ethertype to be set to 0. Check this in >fl_set_key_vlan. >
Powered by blists - more mailing lists