lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220412064940.14798-1-guozhengkui@vivo.com> Date: Tue, 12 Apr 2022 14:46:20 +0800 From: Guo Zhengkui <guozhengkui@...o.com> To: Ilya Dryomov <idryomov@...il.com>, Jeff Layton <jlayton@...nel.org>, Xiubo Li <xiubli@...hat.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Guo Zhengkui <guozhengkui@...o.com>, ceph-devel@...r.kernel.org (open list:CEPH COMMON CODE (LIBCEPH)), netdev@...r.kernel.org (open list:NETWORKING [GENERAL]), linux-kernel@...r.kernel.org (open list) Cc: zhengkui_guo@...look.com Subject: [PATCH linux-next] net: ceph: use swap() macro instead of taking tmp variable Fix the following coccicheck warning: net/ceph/crush/mapper.c:1077:8-9: WARNING opportunity for swap() by using swap() for the swapping of variable values and drop the tmp variable that is not needed any more. Signed-off-by: Guo Zhengkui <guozhengkui@...o.com> --- net/ceph/crush/mapper.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c index 7057f8db4f99..1daf95e17d67 100644 --- a/net/ceph/crush/mapper.c +++ b/net/ceph/crush/mapper.c @@ -906,7 +906,6 @@ int crush_do_rule(const struct crush_map *map, int recurse_to_leaf; int wsize = 0; int osize; - int *tmp; const struct crush_rule *rule; __u32 step; int i, j; @@ -1073,9 +1072,7 @@ int crush_do_rule(const struct crush_map *map, memcpy(o, c, osize*sizeof(*o)); /* swap o and w arrays */ - tmp = o; - o = w; - w = tmp; + swap(o, w); wsize = osize; break; -- 2.20.1
Powered by blists - more mailing lists