lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2022 05:59:15 -0700 From: Richard Cochran <richardcochran@...il.com> To: Tan Tee Min <tee.min.tan@...el.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Rayagond Kokatanur <rayagond@...avyalabs.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Voon Wei Feng <weifeng.voon@...el.com>, Wong Vee Khee <vee.khee.wong@...el.com>, Song Yoong Siang <yoong.siang.song@...el.com> Subject: Re: [PATCH net 1/1] net: stmmac: add fsleep() in HW Rx timestamp checking loop On Wed, Apr 13, 2022 at 12:01:15PM +0800, Tan Tee Min wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > index d3b4765c1a5b..289bf26a6105 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c > @@ -279,10 +279,11 @@ static int dwmac4_wrback_get_rx_timestamp_status(void *desc, void *next_desc, > /* Check if timestamp is OK from context descriptor */ > do { > ret = dwmac4_rx_check_timestamp(next_desc); > - if (ret < 0) > + if (ret <= 0) > goto exit; > i++; > > + fsleep(1); This is nutty. Why isn't this code using proper deferral mechanisms like work or kthread? > } while ((ret == 1) && (i < 10)); > > if (i == 10) > -- > 2.25.1 > Thanks, Richard
Powered by blists - more mailing lists