lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Apr 2022 12:59:06 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Andrii Nakryiko <andrii.nakryiko@...il.com> Cc: Masami Hiramatsu <mhiramat@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org> Subject: Re: [RFC bpf-next 4/4] selftests/bpf: Add attach bench test On Wed, 13 Apr 2022 09:45:52 -0700 Andrii Nakryiko <andrii.nakryiko@...il.com> wrote: > > Did you only use the "notrace" on the prototype? I see the semicolon at > > the end of your comment. It only affects the actual function itself, > > not the prototype. > > notrace is both on declaration and on definition, see kernel/bpf/trampoline.c: OK. Note, it only needs to be on the function, the prototype doesn't do anything. But that shouldn't be the issue. > > void notrace __bpf_tramp_exit(struct bpf_tramp_image *tr) > { > percpu_ref_put(&tr->pcref); > } > What compiler are you using? as this seems to be a compiler bug. Because it's not ftrace that picks what functions to trace, but the compiler itself. -- Steve
Powered by blists - more mailing lists