netdev - Re: [PATCH] wireless: ipw2x00: Refine the error handling of ipw2100_pci_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 14:39:54 -0400
From:   Stanislav Yakovlev <stas.yakovlev@...il.com>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     kvalo@...nel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, pabeni@...hat.com,
        wireless <linux-wireless@...r.kernel.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: ipw2x00: Refine the error handling of ipw2100_pci_init_one()

On Sat, 9 Apr 2022 at 02:25, Zheyu Ma <zheyuma97@...il.com> wrote:
>
> The driver should release resources in reverse order, i.e., the
> resources requested first should be released last, and the driver
> should adjust the order of error handling code by this rule.
>
> Signed-off-by: Zheyu Ma <zheyuma97@...il.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c | 34 +++++++++-----------
>  1 file changed, 16 insertions(+), 18 deletions(-)
>
[Skipped]

> @@ -6306,9 +6303,13 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev,
>  out:
>         return err;
>
> -      fail_unlock:
> +fail_unlock:
>         mutex_unlock(&priv->action_mutex);
> -      fail:
> +fail:
> +       pci_release_regions(pci_dev);
> +fail_disable:
> +       pci_disable_device(pci_dev);
We can't move these functions before the following block.

> +fail_dev:
>         if (dev) {
>                 if (registered >= 2)
>                         unregister_netdev(dev);
This block continues with a function call to ipw2100_hw_stop_adapter
which assumes that device is still accessible via pci bus.

> @@ -6334,11 +6335,8 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev,
>
>                 free_libipw(dev, 0);
>         }
> -
> +fail_iounmap:
>         pci_iounmap(pci_dev, ioaddr);
> -
> -       pci_release_regions(pci_dev);
> -       pci_disable_device(pci_dev);
>         goto out;
>  }
>
> --
> 2.25.1
>

Stanislav.