netdev - RE: [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Apr 2022 02:59:32 +0000
From:   Dylan Hung <dylan_hung@...eedtech.com>
To:     Joel Stanley <joel@....id.au>
CC:     Rob Herring <robh+dt@...nel.org>, Andrew Jeffery <andrew@...id.au>,
        Andrew Lunn <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        BMC-SW <BMC-SW@...eedtech.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: RE: [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed,
 ast2600-mdio binding

> -----Original Message-----
> From: Joel Stanley [mailto:joel@....id.au]
> Sent: 2022年4月13日 10:34 AM
> To: Dylan Hung <dylan_hung@...eedtech.com>
> Cc: Rob Herring <robh+dt@...nel.org>; Andrew Jeffery <andrew@...id.au>;
> Andrew Lunn <andrew@...n.ch>; hkallweit1@...il.com; Russell King
> <linux@...linux.org.uk>; David S . Miller <davem@...emloft.net>; Jakub
> Kicinski <kuba@...nel.org>; pabeni@...hat.com; Philipp Zabel
> <p.zabel@...gutronix.de>; devicetree <devicetree@...r.kernel.org>; Linux
> ARM <linux-arm-kernel@...ts.infradead.org>; linux-aspeed
> <linux-aspeed@...ts.ozlabs.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; Networking <netdev@...r.kernel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; BMC-SW
> <BMC-SW@...eedtech.com>; Krzysztof Kozlowski <krzk@...nel.org>
> Subject: Re: [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed,
> ast2600-mdio binding
> 
> On Tue, 12 Apr 2022 at 06:55, Dylan Hung <dylan_hung@...eedtech.com>
> wrote:
> >
> > The AST2600 MDIO bus controller has a reset control bit and must be
> > deasserted before manipulating the MDIO controller. By default, the
> > hardware asserts the reset so the driver only need to deassert it.
> >
> > Regarding to the old DT blobs which don't have reset property in them,
> > the reset deassertion is usually done by the bootloader so the reset
> > property is optional to work with them.
> >
> > Signed-off-by: Dylan Hung <dylan_hung@...eedtech.com>
> > Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >  .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml         | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> > b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> > index 1c88820cbcdf..1174c14898e1 100644
> > --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> > +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> > @@ -20,10 +20,14 @@ allOf:
> >  properties:
> >    compatible:
> >      const: aspeed,ast2600-mdio
> > +
> >    reg:
> >      maxItems: 1
> >      description: The register range of the MDIO controller instance
> >
> > +  resets:
> > +    maxItems: 1
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -39,6 +43,7 @@ examples:
> >              reg = <0x1e650000 0x8>;
> >              #address-cells = <1>;
> >              #size-cells = <0>;
> > +            resets = <&syscon ASPEED_RESET_MII>;
> 
> You will need to include the definition for ASPEED_RESET_MII at the start of
> the example:
> 
> #include <dt-bindings/clock/ast2600-clock.h>
> 
> You can test the bindings example by doing this:
> 
> pip install dtschema
> 
> make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/aspeed,ast2600-
> mdio.yaml
> 

Thank you for your comment, I have reproduced this error and fixed it on my side.
The change will be included in V5.

> Cheers,
> 
> Joel
> 
> >
> >              ethphy0: ethernet-phy@0 {
> >                      compatible = "ethernet-phy-ieee802.3-c22";
> > --
> > 2.25.1
> >