netdev - Re: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ylgjab6qLsrzKZKc@lunn.ch>
Date:   Thu, 14 Apr 2022 15:36:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Wells Lu <wellslutw@...il.com>, davem@...emloft.net,
        robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        p.zabel@...gutronix.de, pabeni@...hat.com, krzk+dt@...nel.org,
        roopa@...dia.com, edumazet@...gle.com, wells.lu@...plus.com
Subject: Re: [PATCH net-next v8 2/2] net: ethernet: Add driver for Sunplus
 SP7021

> > +		/* Get mac-address from nvmem. */
> > +		ret = spl2sw_nvmem_get_mac_address(&pdev->dev, port_np, mac_addr);
> > +		if (ret) {
> > +			dev_info(&pdev->dev, "Generate a random mac address!\n");
> > +
> > +			/* Generate a mac address using OUI of Sunplus Technology
> > +			 * and random controller number.
> > +			 */
> > +			mac_addr[0] = 0xfc; /* OUI of Sunplus: fc:4b:bc */
> > +			mac_addr[1] = 0x4b;
> > +			mac_addr[2] = 0xbc;
> > +			mac_addr[3] = get_random_int() % 256;
> > +			mac_addr[4] = get_random_int() % 256;
> > +			mac_addr[5] = get_random_int() % 256;
> 
> I don't think you can do that. Either you use your OUI and assign the
> address at manufacture or you must use a locally administered address.
> And if locally administered address is used it better be completely
> random to lower the probability of collision to absolute minimum.

I commented about that in an earlier version of these patches. We
probably need a quote from the 802.1 or 802.3 which says this is O.K.

	 Andrew