netdev - Re: [PATCH bpf-next v3 2/3] net: change skb_ensure_writable()'s write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2AA08189-EB2F-4240-8FD8-49F5A4786500@fb.com>
Date:   Thu, 14 Apr 2022 22:28:15 +0000
From:   Song Liu <songliubraving@...com>
To:     Liu Jian <liujian56@...wei.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "sdf@...gle.com" <sdf@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH bpf-next v3 2/3] net: change skb_ensure_writable()'s
 write_len param to unsigned int type



> On Apr 14, 2022, at 6:59 AM, Liu Jian <liujian56@...wei.com> wrote:
> 
> Both pskb_may_pull() and skb_clone_writable()'s length parameters are of
> type unsigned int already.
> Therefore, change this function's write_len param to unsigned int type.
> 
> Signed-off-by: Liu Jian <liujian56@...wei.com>

Acked-by: Song Liu <songliubraving@...com>

> ---
> include/linux/skbuff.h | 2 +-
> net/core/skbuff.c      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 3a30cae8b0a5..fe8990ce52a8 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -3886,7 +3886,7 @@ struct sk_buff *skb_segment(struct sk_buff *skb, netdev_features_t features);
> struct sk_buff *skb_segment_list(struct sk_buff *skb, netdev_features_t features,
> 				 unsigned int offset);
> struct sk_buff *skb_vlan_untag(struct sk_buff *skb);
> -int skb_ensure_writable(struct sk_buff *skb, int write_len);
> +int skb_ensure_writable(struct sk_buff *skb, unsigned int write_len);
> int __skb_vlan_pop(struct sk_buff *skb, u16 *vlan_tci);
> int skb_vlan_pop(struct sk_buff *skb);
> int skb_vlan_push(struct sk_buff *skb, __be16 vlan_proto, u16 vlan_tci);
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 30b523fa4ad2..a84e00e44ad2 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -5601,7 +5601,7 @@ struct sk_buff *skb_vlan_untag(struct sk_buff *skb)
> }
> EXPORT_SYMBOL(skb_vlan_untag);
> 
> -int skb_ensure_writable(struct sk_buff *skb, int write_len)
> +int skb_ensure_writable(struct sk_buff *skb, unsigned int write_len)
> {
> 	if (!pskb_may_pull(skb, write_len))
> 		return -ENOMEM;
> -- 
> 2.17.1
>