netdev - Re: [PATCH iproute2-next] iplink: bond_slave: add per port prio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed68e688-0157-51a6-d6d0-5b66735343a1@gmail.com>
Date:   Wed, 13 Apr 2022 18:44:50 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH iproute2-next] iplink: bond_slave: add per port prio
 support

On 4/11/22 10:17 PM, Hangbin Liu wrote:
> diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
> index d488aaab..7a4d89ff 100644
> --- a/ip/iplink_bond_slave.c
> +++ b/ip/iplink_bond_slave.c
> @@ -19,7 +19,7 @@
>  
>  static void print_explain(FILE *f)
>  {
> -	fprintf(f, "Usage: ... bond_slave [ queue_id ID ]\n");
> +	fprintf(f, "Usage: ... bond_slave [ queue_id ID ] [ prio PRIORITY ]\n");
>  }
>  
>  static void explain(void)
> @@ -120,6 +120,12 @@ static void bond_slave_print_opt(struct link_util *lu, FILE *f, struct rtattr *t
>  			  "queue_id %d ",
>  			  rta_getattr_u16(tb[IFLA_BOND_SLAVE_QUEUE_ID]));
>  
> +	if (tb[IFLA_BOND_SLAVE_PRIO])
> +		print_int(PRINT_ANY,
> +			  "prio",
> +			  "prio %d ",

those last 2 lines can go on the first.

Also, seems like a man page should be updated as well.