lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 Apr 2022 09:31:56 +0200
From:   Oliver Neukum <>
To:     Dan Carpenter <>,
        David Kahurani <>
        syzbot <>,,,,,,
        Phillip Potter <>,,,
        Pavel Skripkin <>
Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read

On 13.04.22 17:32, Dan Carpenter wrote:
> Bug: buffer partially filled.  Information leak.
> If you return the bytes then the only correct way to write error
> handling is:
> 	if (ret < 0)
> 		return ret;
> 	if (ret != size)
> 		return -EIO;
You have to make up your mind on whether you ever need to read
answer of a length not known before you try it. The alternative of
passing a pointer to an integer for length is worse.


Powered by blists - more mailing lists