netdev - Re: [PATCH net-next] net: dsa: realtek: add compatible strings for RTL8367RB-VB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220414113718.ofhgzhsmvyuxd2l2@bang-olufsen.dk>
Date:   Thu, 14 Apr 2022 11:37:19 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "tobias@...dekranz.com" <tobias@...dekranz.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "vladimir.oltean@....com" <vladimir.oltean@....com>,
        "corbet@....net" <corbet@....net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next] net: dsa: realtek: add compatible strings for
 RTL8367RB-VB

On Wed, Apr 13, 2022 at 11:32:42PM -0300, Luiz Angelo Daros de Luca wrote:
> > While the code is OK, on second thought I think based on Andrew's points in the
> > other subthread that we are better off without this patch.
> 
> I agree, although the rtl8365mb name will make it harder for a
> newcomer to find the driver.

If it is made clear in the DT bindings, I think it's fine. If it works for
Marvell switches, it will work for Realtek switches too.

> 
> Is it too late to get rid of all those compatible strings from
> dt-bindings? And rtl8367s from the driver?
> We must add all supported devices to the doc as well, similar to mv88e6085.

You can always try! I'm OK with those things in principle, but others might
object due to ABI reasons.

Don't get hung up on the vestigial "realtek,rtl8367s" compatible string
though... while it's probably harmless to remove it, it's also relatively
harmless to leave it there. Linux is full of such examples.

Kind regards,
Alvin