netdev - Re: [PATCH bpf-next v2 0/6] bpf trampoline for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9667d4b-5246-ee49-22af-c05ffeeaa679@huawei.com>
Date:   Fri, 15 Apr 2022 11:47:56 +0800
From:   Xu Kuohai <xukuohai@...wei.com>
To:     Hou Tao <houtao1@...wei.com>, <bpf@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>
CC:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Zi Shen Lim <zlim.lnx@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        <hpa@...or.com>, Shuah Khan <shuah@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Peter Collingbourne <pcc@...gle.com>,
        Daniel Kiss <daniel.kiss@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Steven Price <steven.price@....com>,
        Marc Zyngier <maz@...nel.org>, Mark Brown <broonie@...nel.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Delyan Kratunov <delyank@...com>
Subject: Re: [PATCH bpf-next v2 0/6] bpf trampoline for arm64

On 4/15/2022 10:37 AM, Hou Tao wrote:
> Hi,
> 
> On 4/15/2022 12:22 AM, Xu Kuohai wrote:
>> Add bpf trampoline support for arm64. Most of the logic is the same as
>> x86.
>>
>> Tested on qemu, result:
>>  #55 fentry_fexit:OK
>>  #56 fentry_test:OK
>>  #58 fexit_sleep:OK
>>  #59 fexit_stress:OK
>>  #60 fexit_test:OK
>>  #67 get_func_args_test:OK
>>  #68 get_func_ip_test:OK
>>  #101 modify_return:OK
> bpf_struct_ops also depends on bpf trampoline, could you please also add the
> test results for bpf_struct_ops related tests case ?

Yes, more tests is needed. I'm curently testing with bpftrace's kfunc
and bpf selftest, more testing results will be posted.

>>
>> v2:
>> - Add Song's ACK
>> - Change the multi-line comment in is_valid_bpf_tramp_flags() into net
>>   style (patch 3)
>> - Fix a deadloop issue in ftrace selftest (patch 2)
>> - Replace pt_regs->x0 with pt_regs->orig_x0 in patch 1 commit message 
>> - Replace "bpf trampoline" with "custom trampoline" in patch 1, as
>>   ftrace direct call is not only used by bpf trampoline.
>>
>> v1: https://lore.kernel.org/bpf/20220413054959.1053668-1-xukuohai@huawei.com/
>>
>> Xu Kuohai (6):
>>   arm64: ftrace: Add ftrace direct call support
>>   ftrace: Fix deadloop caused by direct call in ftrace selftest
>>   bpf: Move is_valid_bpf_tramp_flags() to the public trampoline code
>>   bpf, arm64: Impelment bpf_arch_text_poke() for arm64
>>   bpf, arm64: bpf trampoline for arm64
>>   selftests/bpf: Fix trivial typo in fentry_fexit.c
>>
>>  arch/arm64/Kconfig                            |   2 +
>>  arch/arm64/include/asm/ftrace.h               |  10 +
>>  arch/arm64/kernel/asm-offsets.c               |   1 +
>>  arch/arm64/kernel/entry-ftrace.S              |  28 +-
>>  arch/arm64/net/bpf_jit.h                      |  14 +-
>>  arch/arm64/net/bpf_jit_comp.c                 | 390 +++++++++++++++++-
>>  arch/x86/net/bpf_jit_comp.c                   |  20 -
>>  include/linux/bpf.h                           |   5 +
>>  kernel/bpf/bpf_struct_ops.c                   |   4 +-
>>  kernel/bpf/trampoline.c                       |  35 +-
>>  kernel/trace/trace_selftest.c                 |   4 +-
>>  .../selftests/bpf/prog_tests/fentry_fexit.c   |   4 +-
>>  12 files changed, 482 insertions(+), 35 deletions(-)
>>
> 
> .