lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YlmbIjoIZ8Xb4Kh/@lunn.ch> Date: Fri, 15 Apr 2022 18:19:46 +0200 From: Andrew Lunn <andrew@...n.ch> To: Clément Léger <clement.leger@...tlin.com> Cc: Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Herve Codina <herve.codina@...tlin.com>, Miquèl Raynal <miquel.raynal@...tlin.com>, Milan Stevanovic <milan.stevanovic@...com>, Jimmy Lalande <jimmy.lalande@...com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next 09/12] ARM: dts: r9a06g032: describe MII converter > I think it would be good to modify it like this: > > eth-miic@...30000 { > ... > converters { > mii_conv0: mii-conv@0 { > // Even if useless, maybe keeping it for the sake of coherency > renesas,miic-input = <MIIC_GMAC1>; > reg = <0>; > }; This is not a 'bus', so using reg, and @0, etc is i think wrong. You just have a collection of properties. > mii_conv1: mii-conv@1 { > renesas,miic-input = <SWITCH_PORTA>; > reg = <1>; > }; > mii_conv2: mii-conv@2 { > renesas,miic-input = <SWITCH_PORTB>; > reg = <2>; > }; > mii_conv3: mii-conv@3 { > renesas,miic-input = <SWITCH_PORTC>; > reg = <3>; > }; > mii_conv4: mii-conv@4 { > renesas,miic-input = <SWITCH_PORTD>; > reg = <4>; > }; > }; > > This way, it remains tied to the MII converter output port definition. I > guess that the yaml definitions would still allow to restrict the values > available per nodes. Validation for the final combination is probably > more difficult to do using yaml. I doubt you can do full validation in YAML. But you can at least limit some of the errors. You need to do full validation in the driver anyway. Andrew
Powered by blists - more mailing lists