lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220415122432.5db0de59@hermes.local> Date: Fri, 15 Apr 2022 12:24:32 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Florent Fourcot <florent.fourcot@...irst.fr> Cc: netdev@...r.kernel.org, cong.wang@...edance.com, edumazet@...gle.com, Brian Baboch <brian.baboch@...irst.fr> Subject: Re: [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given On Fri, 15 Apr 2022 18:53:27 +0200 Florent Fourcot <florent.fourcot@...irst.fr> wrote: > if (!(nlh->nlmsg_flags & NLM_F_CREATE)) { > - if (ifm->ifi_index == 0 && tb[IFLA_GROUP]) > + /* No dev found and NLM_F_CREATE not set. Requested dev does not exist, > + * or it's for a group > + */ > + if (link_specified) > + return -ENODEV; Please add extack error message as well? Simple errno's are harder to debug.
Powered by blists - more mailing lists