lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ca2944bd-e80e-e0ff-0804-c8439f54b28a@quicinc.com> Date: Fri, 15 Apr 2022 16:02:57 -0700 From: Jeff Johnson <quic_jjohnson@...cinc.com> To: Yihao Han <hanyihao@...o.com>, Kalle Valo <kvalo@...nel.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, <ath11k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: <kernel@...o.com> Subject: Re: [PATCH v2] ath11k: simplify if-if to if-else On 4/15/2022 5:58 AM, Yihao Han wrote: > Replace `if (!ab->is_reset)` with `else` for simplification > according to the kernel coding style: > > "Do not unnecessarily use braces where a single statement will do." > > ... > > "This does not apply if only one branch of a conditional statement is > a single statement; in the latter case use braces in both branches" > > Please refer to: > https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html why are you referring to braces when your patch has nothing to do with braces? changing if (foo) X;if (!foo) Y; to if (foo) X else Y; is not a design pattern referenced in the coding style > > Suggested-by: Benjamin Poirier <benjamin.poirier@...il.com> > Signed-off-by: Yihao Han <hanyihao@...o.com> > --- > v2:edit commit message > --- > drivers/net/wireless/ath/ath11k/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c > index cbac1919867f..80009482165a 100644 > --- a/drivers/net/wireless/ath/ath11k/core.c > +++ b/drivers/net/wireless/ath/ath11k/core.c > @@ -1532,8 +1532,7 @@ static void ath11k_core_restart(struct work_struct *work) > > if (ab->is_reset) > complete_all(&ab->reconfigure_complete); > - > - if (!ab->is_reset) > + else > ath11k_core_post_reconfigure_recovery(ab); > } >
Powered by blists - more mailing lists