netdev - Re: [PATCH] net: qlogic: qlcnic: simplify if-if to if-else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c579fa38-5cac-1c51-5cdb-ac366b6043b7@vivo.com>
Date:   Fri, 15 Apr 2022 14:17:17 +0800
From:   Yihao Han <hanyihao@...o.com>
To:     Benjamin Poirier <benjamin.poirier@...il.com>
Cc:     Shahed Shaikh <shshaikh@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        GR-Linux-NIC-Dev@...vell.com,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...o.com
Subject: Re: [PATCH] net: qlogic: qlcnic: simplify if-if to if-else



在 2022/4/15 13:48, Benjamin Poirier 写道:
> On 2022-04-13 20:11 -0700, Yihao Han wrote:
>> Replace `if (!pause->autoneg)` with `else` for simplification
>> and add curly brackets according to the kernel coding style:
>>
>> "Do not unnecessarily use braces where a single statement will do."
>>
>> ...
>>
>> "This does not apply if only one branch of a conditional statement is
>> a single statement; in the latter case use braces in both branches"
>>
>> Please refer to:
>> https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html
> 
> Seems the part of the log about curly brackets doesn't correspond with
> the actual changes.
> 
>>
>> Signed-off-by: Yihao Han <hanyihao@...o.com>
>> ---
>>   drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
>> index bd0607680329..e3842eaf1532 100644
>> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
>> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
>> @@ -3752,7 +3752,7 @@ int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
>>   	if (ahw->port_type == QLCNIC_GBE) {
>>   		if (pause->autoneg)
>>   			ahw->port_config |= QLC_83XX_ENABLE_AUTONEG;
>> -		if (!pause->autoneg)
>> +		else
>>   			ahw->port_config &= ~QLC_83XX_ENABLE_AUTONEG;
>>   	} else if ((ahw->port_type == QLCNIC_XGBE) && (pause->autoneg)) {
>>   		return -EOPNOTSUPP;
>> -- 
>> 2.17.1
>>
Sorry that I made a mistake. I will send a v2 patch about this.
Thanks for your review.

regards,
Yihao