lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220415092300.009ef819@fixe.home> Date: Fri, 15 Apr 2022 09:23:00 +0200 From: Clément Léger <clement.leger@...tlin.com> To: "Russell King (Oracle)" <linux@...linux.org.uk> Cc: Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Heiner Kallweit <hkallweit1@...il.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Herve Codina <herve.codina@...tlin.com>, Miquèl Raynal <miquel.raynal@...tlin.com>, Milan Stevanovic <milan.stevanovic@...com>, Jimmy Lalande <jimmy.lalande@...com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next 02/12] net: dsa: add Renesas RZ/N1 switch tag driver Le Thu, 14 Apr 2022 17:23:46 +0100, "Russell King (Oracle)" <linux@...linux.org.uk> a écrit : > On Thu, Apr 14, 2022 at 06:18:15PM +0200, Clément Léger wrote: > > Le Thu, 14 Apr 2022 18:11:46 +0300, > > Vladimir Oltean <olteanv@...il.com> a écrit : > > > > > On Thu, Apr 14, 2022 at 04:35:46PM +0200, Clément Léger wrote: > > > > > Please keep variable declarations sorted in decreasing order of line > > > > > length (applies throughout the patch series, I won't repeat this comment). > > > > > > > > Acked, both PCS and DSA driver are ok with that rule. Missed that one > > > > though. > > > > > > Are you sure? Because a5psw_port_stp_state_set() says otherwise. > > > > Weeeeell, ok let's say I missed these two. Would be useful to have such > > checks in checkpatch.pl. > > Note that it's a local networking coding-style issue, rather than being > kernel-wide. > Hi Russell, Yes I was aware of that but if I remember correctly, there are some netowrking checks like multi line comments without an empty first line in checkpatch. Anyway, I'll make sure to check that mroe carefully next time. -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
Powered by blists - more mailing lists