lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220415023957.1117879-1-yangyingliang@huawei.com> Date: Fri, 15 Apr 2022 10:39:57 +0800 From: Yang Yingliang <yangyingliang@...wei.com> To: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> CC: <vburru@...vell.com>, <aayarekar@...vell.com>, <sburla@...vell.com>, <davem@...emloft.net> Subject: [PATCH -next] octeon_ep: fix error return code in octep_probe() If register_netdev() fails , it should return error code in octep_probe(). Fixes: 862cd659a6fb ("octeon_ep: Add driver framework and device initialization") Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com> --- drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 5d39c857ea41..f2af5ebffcf1 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -1071,7 +1071,8 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) octep_get_mac_addr(octep_dev, octep_dev->mac_addr); eth_hw_addr_set(netdev, octep_dev->mac_addr); - if (register_netdev(netdev)) { + err = register_netdev(netdev); + if (err) { dev_err(&pdev->dev, "Failed to register netdev\n"); goto register_dev_err; } -- 2.25.1
Powered by blists - more mailing lists