lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Apr 2022 11:07:24 +0000 From: Alvin Šipraga <ALSI@...g-olufsen.dk> To: Luiz Angelo Daros de Luca <luizluca@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "andrew@...n.ch" <andrew@...n.ch>, "vivien.didelot@...il.com" <vivien.didelot@...il.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "olteanv@...il.com" <olteanv@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>, "arinc.unal@...nc9.com" <arinc.unal@...nc9.com> Subject: Re: [PATCH net 2/2] net: dsa: realtek: remove realtek,rtl8367s string On Sat, Apr 16, 2022 at 03:25:04AM -0300, Luiz Angelo Daros de Luca wrote: > There is no need to add new compatible strings for each new supported > chip version. The compatible string is used only to select the subdriver > (rtl8365mb.c or rtl8366rb). Once in the subdriver, it will detect the > chip model by itself, ignoring which compatible string was used. > > Link: https://lore.kernel.org/netdev/20220414014055.m4wbmr7tdz6hsa3m@bang-olufsen.dk/ > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com> > --- Hi Luiz, I think it's great that you identified this early enough to remove the redundant compatible string before it hits an official release. Now we have well-defined semantics regarding the compatible strings, which is great :) Reviewed-by: Alvin ┼áipraga <alsi@...g-olufsen.dk> > drivers/net/dsa/realtek/realtek-mdio.c | 1 - > drivers/net/dsa/realtek/realtek-smi.c | 4 ---- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c > index 31e1f100e48e..c58f49d558d2 100644 > --- a/drivers/net/dsa/realtek/realtek-mdio.c > +++ b/drivers/net/dsa/realtek/realtek-mdio.c > @@ -267,7 +267,6 @@ static const struct of_device_id realtek_mdio_of_match[] = { > #endif > #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB) > { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, > - { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant, }, > #endif > { /* sentinel */ }, > }; > diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c > index 6cec559c90ce..45992f79ec8d 100644 > --- a/drivers/net/dsa/realtek/realtek-smi.c > +++ b/drivers/net/dsa/realtek/realtek-smi.c > @@ -551,10 +551,6 @@ static const struct of_device_id realtek_smi_of_match[] = { > .compatible = "realtek,rtl8365mb", > .data = &rtl8365mb_variant, > }, > - { > - .compatible = "realtek,rtl8367s", > - .data = &rtl8365mb_variant, > - }, > #endif > { /* sentinel */ }, > }; > -- > 2.35.1 >
Powered by blists - more mailing lists