lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM_iQpXb=-hdGbdbpTbDBGJKyYPhn3SxXUUowHg5gTy20W=iiQ@mail.gmail.com> Date: Sun, 17 Apr 2022 15:30:01 -0700 From: Cong Wang <xiyou.wangcong@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, netdev <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH net-next] net_sched: make qdisc_reset() smaller On Wed, Apr 13, 2022 at 6:11 PM Eric Dumazet <eric.dumazet@...il.com> wrote: > > From: Eric Dumazet <edumazet@...gle.com> > > For some unknown reason qdisc_reset() is using > a convoluted way of freeing two lists of skbs. > > Use __skb_queue_purge() instead. [...] > > - skb_queue_walk_safe(&qdisc->gso_skb, skb, tmp) { > - __skb_unlink(skb, &qdisc->gso_skb); > - kfree_skb_list(skb); Isn't it precisely because of this kfree_skb_list()? Thanks.
Powered by blists - more mailing lists