netdev - Re: [PATCH ethtool-next] ethtool: netlink: add support to get/set tx push by ethtool -G/g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b67ba4e-c470-bb78-392c-dc9a187ea7b8@huawei.com>
Date:   Tue, 19 Apr 2022 21:20:05 +0800
From:   "wangjie (L)" <wangjie125@...wei.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        Guangbin Huang <huangguangbin2@...wei.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <lipeng321@...wei.com>
Subject: Re: [PATCH ethtool-next] ethtool: netlink: add support to get/set tx
 push by ethtool -G/g



On 2022/4/19 21:07, Michal Kubecek wrote:
> On Tue, Apr 19, 2022 at 08:50:30PM +0800, Guangbin Huang wrote:
>> From: Jie Wang <wangjie125@...wei.com>
>>
>> Currently tx push is a standard feature for NICs such as Mellanox, HNS3.
>> But there is no command to set or get this feature.
>>
>> So this patch adds support for "ethtool -G <dev> tx-push on|off" and
>> "ethtool -g <dev>" to set/get tx push mode.
>>
>> Signed-off-by: Jie Wang <wangjie125@...wei.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
>> ---
> [...]
>> diff --git a/uapi/linux/ethtool_netlink.h b/uapi/linux/ethtool_netlink.h
>> index d8b19cf98003..79fe0bf686f3 100644
>> --- a/uapi/linux/ethtool_netlink.h
>> +++ b/uapi/linux/ethtool_netlink.h
>> @@ -330,6 +330,7 @@ enum {
>>  	ETHTOOL_A_RINGS_RX_JUMBO,			/* u32 */
>>  	ETHTOOL_A_RINGS_TX,				/* u32 */
>>  	ETHTOOL_A_RINGS_RX_BUF_LEN,                     /* u32 */
>> +	ETHTOOL_A_RINGS_TX_PUSH = 13,			/* u8  */
>>
>>  	/* add new constants above here */
>>  	__ETHTOOL_A_RINGS_CNT,
>
> Please update the uapi headers from sanitized kernel headers as
> described here:
>
>   https://www.kernel.org/pub/software/network/ethtool/devel.html
>
> (the paragraph starting "If you need new or updated definitions..." near
> the end of the page).
>
> Michal
Thank you for your guidance. I will use the method to update the uapi 
headers in patch v2
>