netdev - Re: [PATCH net-next 2/2] net: vxlan: vxlan_core.c: Add extack support to vxlan_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7f8ba31-e056-b8f6-d496-9c04ed15e852@nvidia.com>
Date:   Tue, 19 Apr 2022 07:54:48 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>,
        netdev@...r.kernel.org
Cc:     outreachy@...ts.linux.dev, roopa.prabhu@...il.com,
        jdenham@...hat.com, sbrivio@...hat.com
Subject: Re: [PATCH net-next 2/2] net: vxlan: vxlan_core.c: Add extack support
 to vxlan_fdb_delet


On 4/19/22 07:37, Alaa Mohamed wrote:
> Add extack to vxlan_fdb_delet and vxlan_fdb_parse
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> ---

Alaa, minor nit: fix spelling vxlan_fdb_delete


>   drivers/net/vxlan/vxlan_core.c | 13 ++++++++++---
>   1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index cf2f60037340..4ecbb5878fe2 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1129,18 +1129,20 @@ static void vxlan_fdb_dst_destroy(struct vxlan_dev *vxlan, struct vxlan_fdb *f,
>
>   static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>   			   union vxlan_addr *ip, __be16 *port, __be32 *src_vni,
> -			   __be32 *vni, u32 *ifindex, u32 *nhid)
> +			   __be32 *vni, u32 *ifindex, u32 *nhid, struct netlink_ext_ack *extack)
>   {
>   	struct net *net = dev_net(vxlan->dev);
>   	int err;
>
>   	if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
>   	    tb[NDA_PORT]))
> +		NL_SET_ERR_MSG(extack, "Missing required arguments");
>   		return -EINVAL;
>
>   	if (tb[NDA_DST]) {
>   		err = vxlan_nla_get_addr(ip, tb[NDA_DST]);
>   		if (err)
> +			NL_SET_ERR_MSG(extack, "Unsupported address family");
>   			return err;
>   	} else {
>   		union vxlan_addr *remote = &vxlan->default_dst.remote_ip;
> @@ -1158,6 +1160,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>
>   	if (tb[NDA_PORT]) {
>   		if (nla_len(tb[NDA_PORT]) != sizeof(__be16))
> +			NL_SET_ERR_MSG(extack, "Invalid vxlan port");
>   			return -EINVAL;
>   		*port = nla_get_be16(tb[NDA_PORT]);
>   	} else {
> @@ -1166,6 +1169,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>
>   	if (tb[NDA_VNI]) {
>   		if (nla_len(tb[NDA_VNI]) != sizeof(u32))
> +			NL_SET_ERR_MSG(extack, "Invalid vni");
>   			return -EINVAL;
>   		*vni = cpu_to_be32(nla_get_u32(tb[NDA_VNI]));
>   	} else {
> @@ -1174,6 +1178,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>
>   	if (tb[NDA_SRC_VNI]) {
>   		if (nla_len(tb[NDA_SRC_VNI]) != sizeof(u32))
> +			NL_SET_ERR_MSG(extack, "Invalid src vni");
>   			return -EINVAL;
>   		*src_vni = cpu_to_be32(nla_get_u32(tb[NDA_SRC_VNI]));
>   	} else {
> @@ -1184,10 +1189,12 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>   		struct net_device *tdev;
>
>   		if (nla_len(tb[NDA_IFINDEX]) != sizeof(u32))
> +			NL_SET_ERR_MSG(extack, "Invalid ifindex");
>   			return -EINVAL;


Missing braces.

>   		*ifindex = nla_get_u32(tb[NDA_IFINDEX]);
>   		tdev = __dev_get_by_index(net, *ifindex);
>   		if (!tdev)
> +			NL_SET_ERR_MSG(extack,"Device not found");
>   			return -EADDRNOTAVAIL;

same here

>   	} else {
>   		*ifindex = 0;
> @@ -1226,7 +1233,7 @@ static int vxlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>   		return -EINVAL;
>
>   	err = vxlan_fdb_parse(tb, vxlan, &ip, &port, &src_vni, &vni, &ifindex,
> -			      &nhid);
> +			      &nhid, extack);
>   	if (err)
>   		return err;
>
> @@ -1291,7 +1298,7 @@ static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
>   	int err;
>
>   	err = vxlan_fdb_parse(tb, vxlan, &ip, &port, &src_vni, &vni, &ifindex,
> -			      &nhid);
> +			      &nhid, extack);
>   	if (err)
>   		return err;
>
> --
> 2.35.2
>