lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220419153530.w2iovki72udt4o6q@pengutronix.de>
Date:   Tue, 19 Apr 2022 17:35:30 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Pavel Pisa <pisa@....felk.cvut.cz>
Cc:     linux-can@...r.kernel.org, devicetree@...r.kernel.org,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        David Miller <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, mark.rutland@....com,
        Carsten Emde <c.emde@...dl.org>, armbru@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marin Jerabek <martin.jerabek01@...il.com>,
        Ondrej Ille <ondrej.ille@...il.com>,
        Jiri Novak <jnovak@....cvut.cz>,
        Jaroslav Beran <jara.beran@...il.com>,
        Petr Porazil <porazil@...ron.com>, Pavel Machek <pavel@....cz>,
        Drew Fustini <pdp7pdp7@...il.com>,
        Mataj Vasilevski <vasilmat@....cvut.cz>
Subject: Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver,
 PCI, platform integration and documentation

On 06.04.2022 10:20:42, Pavel Pisa wrote:
> Hello Marc and others,
> 
> On Tuesday 22 of March 2022 10:22:12 Marc Kleine-Budde wrote:
> > On 22.03.2022 09:18:32, Pavel Pisa wrote:
> > > > The driver looks much better now. Good work. Please have a look at the
> > > > TX path of the mcp251xfd driver, especially the tx_stop_queue and
> > > > tx_wake_queue in mcp251xfd_start_xmit() and mcp251xfd_handle_tefif(). A
> > > > lockless implementation should work in your hardware, too.
> > >
> > > Is this blocker for now? I would like to start with years tested base.
> >
> > Makes sense.
> 
> I have missed timing for 5.18 but v5.18-rc1 is out so I would be
> happy if we do not miss 5.19 merge window at least with minimal version.

I've taken the patch (almost) as is, I marked both can_bittiming_const
static, as sparse complained about that and I changed the order of two
variable declarations to look nicer :)

Looking forward for more patches!

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ