lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Apr 2022 19:29:13 +0200 From: Artem Savkov <asavkov@...hat.com> To: Daniel Borkmann <daniel@...earbox.net> Cc: Alan Maguire <alan.maguire@...cle.com>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org Subject: Re: [PATCH bpf-next] selftests/bpf: fix prog_tests/uprobe_autoattach compilation error On Thu, Apr 21, 2022 at 06:53:22PM +0200, Daniel Borkmann wrote: > On 4/21/22 3:23 PM, Artem Savkov wrote: > > I am getting the following compilation error for prog_tests/uprobe_autoattach.c > > > > tools/testing/selftests/bpf/prog_tests/uprobe_autoattach.c: In function ‘test_uprobe_autoattach’: > > ./test_progs.h:209:26: error: pointer ‘mem’ may be used after ‘free’ [-Werror=use-after-free] > > > > mem variable is now used in one of the asserts so it shouldn't be freed right > > away. Move free(mem) after the assert block. > > Looks good, but I rephrased this a bit to avoid confusion. It's false positive given we > only compare the addresses but don't deref mem, which the compiler might not be able to > follow in this case. > > https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=6a12b8e20d7e72386594a9dbe7bf2d7fae3b3aa6 Right. Thank you for fixing up the commit message. -- Artem
Powered by blists - more mailing lists