lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 21 Apr 2022 13:23:53 -0700
From:   Tony Nguyen <>
To:     <>,
        Jesse Brandeburg <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Vedang Patel <>,
        Andre Guedes <>,
        Maciej Fijalkowski <>,
        Jithu Joseph <>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        "open list:NETWORKING DRIVERS" <>,
        open list <>
CC:     Jeff Evanson <>
Subject: Re: [PATCH v2 2/2] igc: Trigger proper interrupts in igc_xsk_wakeup

On 4/19/2022 6:26 PM, wrote:
> From: Jeff Evanson <>
> In igc_xsk_wakeup, trigger the proper interrupt based on whether flags
> contains XDP_WAKEUP_RX and/or XDP_WAKEUP_TX.
> Consider a scenario where the transmit queue interrupt is mapped to a
> different irq from the receive queue. If XDP_WAKEUP_TX is set in the
> flags argument, the interrupt for transmit queue must be triggered,
> otherwise the transmit queue's napi_struct will never be scheduled.
> In the case where both XDP_WAKEUP_TX and XDP_WAKEUP_RX are both set,
> the receive interrupt should always be triggered, but the transmit
> interrupt should only be triggered if its q_vector differs from the
> receive queue's interrupt.
> Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")

You're missing your sign-off; same for patch 1. Also, there's a handful 
of issues being reported by checkpatch [1]




Powered by blists - more mailing lists