netdev - Re: [PATCH] can: ctucanfd: Remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Apr 2022 23:17:07 +0200
From:   Pavel Pisa <pisa@....felk.cvut.cz>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     ondrej.ille@...il.com, wg@...ndegger.com, mkl@...gutronix.de,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] can: ctucanfd: Remove unused including <linux/version.h>

Thanks for checking

On Thursday 21 of April 2022 22:28:52 Jiapeng Chong wrote:
> Eliminate the follow versioncheck warning:
>
> ./drivers/net/can/ctucanfd/ctucanfd_base.c: 34 linux/version.h not
> needed.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Pave Pisa <pisa@....felk.cvut.cz>

> ---
>  drivers/net/can/ctucanfd/ctucanfd_base.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_base.c
> b/drivers/net/can/ctucanfd/ctucanfd_base.c index 7a4550f60abb..be90136be442
> 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_base.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_base.c
> @@ -31,7 +31,6 @@
>  #include <linux/can/error.h>
>  #include <linux/can/led.h>
>  #include <linux/pm_runtime.h>
> -#include <linux/version.h>
>
>  #include "ctucanfd.h"
>  #include "ctucanfd_kregs.h"


-- 
Yours sincerely

                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@....felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home