netdev - Re: [PATCH] openvswitch: meter: Remove unnecessary int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84310b72be223d736c8ac9fc58eb4936a98aa839.camel@redhat.com>
Date:   Thu, 21 Apr 2022 10:47:14 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Solomon Tan <solomonbstoner@...tonmail.ch>, pshelar@....org,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        dev@...nvswitch.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] openvswitch: meter: Remove unnecessary int

On Mon, 2022-04-18 at 00:50 +0000, Solomon Tan wrote:
> This patch addresses the checkpatch.pl warning that long long is
> preferred over long long int.

Please don't do that. This kind of changes cause e.g. backporting issue
for any later relevant bugfix touching the same area, for no real
benefit. 

Documentation/process/2.Process.rst

explicltly states to avoid this kind of patches.
> 
> Signed-off-by: Solomon Tan <solomonbstoner@...tonmail.ch>
> ---
>  net/openvswitch/meter.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c
> index 04a060ac7fdf..a790920c11d6 100644
> --- a/net/openvswitch/meter.c
> +++ b/net/openvswitch/meter.c
> @@ -592,8 +592,8 @@ static int ovs_meter_cmd_del(struct sk_buff *skb, struct genl_info *info)
>  bool ovs_meter_execute(struct datapath *dp, struct sk_buff *skb,
>  		       struct sw_flow_key *key, u32 meter_id)
>  {
> -	long long int now_ms = div_u64(ktime_get_ns(), 1000 * 1000);
> -	long long int long_delta_ms;
> +	long long now_ms = div_u64(ktime_get_ns(), 1000 * 1000);
> +	long long long_delta_ms;
>  	struct dp_meter_band *band;
>  	struct dp_meter *meter;
>  	int i, band_exceeded_max = -1;

Additionally the patch is mangled by non plain-text encoding.

For any later submissions (regarding some other different topic) please
ensure that your client/mailer send purely plain-text messages,

Thanks,

Paolo