netdev - Re: [PATCH net-next] 1588 support on bcm54210pe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220422194810.GA9325@hoboy.vegasvil.org>
Date:   Fri, 22 Apr 2022 12:48:10 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Lasse Johnsen <lasse@...ebeat.app>, netdev@...r.kernel.org,
        Gordon Hollingworth <gordon@...pberrypi.com>,
        Ahmad Byagowi <clk@...com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        bcm-kernel-feedback-list@...adcom.com,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next] 1588 support on bcm54210pe

On Fri, Apr 22, 2022 at 05:00:07PM +0200, Andrew Lunn wrote:

> > I am confident that this code is relevant exclusively to the
> > BCM54210PE.

Not true.

> It will not even work with the BCM54210, BCM54210S and
> > BCM54210SE PHYs.

The registers you used are also present in the BCM541xx devices.
Pretty sure your code would work on those devices (after adjusting
register offsets).

> Florian can probably tell us more, but often hardware like this is
> shared by multiple devices. If it is, you might want to use a more
> generic prefix.

My understanding is that there are two implementions, gen1 and gen2.
Your bcm542xx and the bcm541xx are both gen1, and both support inband
Rx time stamping.

Because the registers are all the same (just the offsets are
different), I'd like to see a common module that can be used by all
gen1 devices.  The module could be named bcm-ptp-gen1.c for example.

Thanks,
Richard