netdev - Re: [Patch net-next] net: dsa: ksz: added the generic port_stp_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7316bb36-a5b6-b34a-1299-98605ce9d2c2@gmail.com>
Date:   Sun, 24 Apr 2022 16:01:34 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Arun Ramadoss <arun.ramadoss@...rochip.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Vladimir Oltean <olteanv@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>, UNGLinuxDriver@...rochip.com,
        Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [Patch net-next] net: dsa: ksz: added the generic
 port_stp_state_set function



On 4/24/2022 4:28 AM, Arun Ramadoss wrote:
> The ksz8795 and ksz9477 uses the same algorithm for the
> port_stp_state_set function except the register address is different. So
> moved the algorithm to the ksz_common.c and used the dev_ops for
> register read and write. This function can also used for the lan937x
> part. Hence making it generic for all the parts.
> 
> Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian