netdev - Re: [PATCH net-next 03/28] sfc: Copy shared files needed for Siena

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Apr 2022 08:22:57 +0100
From:   Martin Habets <habetsm.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     pabeni@...hat.com, davem@...emloft.net, netdev@...r.kernel.org,
        ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 03/28] sfc: Copy shared files needed for Siena

On Sat, Apr 23, 2022 at 06:50:07AM -0700, Jakub Kicinski wrote:
> On Fri, 22 Apr 2022 15:57:43 +0100 Martin Habets wrote:
> > From: Martin Habets <martinh@...inx.com>
> > 
> > No changes are done, those will be done with subsequent commits.
> 
> This ginormous patch does not make it thru the mail systems.
> I'm guessing there is a (perfectly reasonable) 1MB limit somewhere.

I think the issue is with mcdi_pcol.h, which is 1.1MB of defines
generated from the hardware databases. It has grown slowely over the
years.
I'll split up this patch and see if I can manually cut down mcdi_pcol.h.

> I think you can also rework the series and combine the pure rename
> patches. Having the renames by header file does not substantially 
> help review.

Ok, will do. I do not want to make individual patches too big.

> Try to stay under the 15 patch limit.

I'll probably need 2 or 3 series, and it means our Siena NICs will
not work after the 1st series.

Thanks for your advice,
Martin