netdev - Re: [PATCH v2 net-next 07/10] net: dsa: request drivers to perform FDB isolation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmgaX4On/2j3lJf/@lunn.ch>
Date:   Tue, 26 Apr 2022 18:14:23 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Hans Schultz <schultz.hans@...il.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        George McCollister <george.mccollister@...il.com>
Subject: Re: [PATCH v2 net-next 07/10] net: dsa: request drivers to perform
 FDB isolation

> > @@ -941,23 +965,29 @@ struct dsa_switch_ops {
> >  	 * Forwarding database
> >  	 */
> >  	int	(*port_fdb_add)(struct dsa_switch *ds, int port,
> > -				const unsigned char *addr, u16 vid);
> > +				const unsigned char *addr, u16 vid,
> > +				struct dsa_db db);
> 
> Hi! Wouldn't it be better to have a struct that has all the functions
> parameters in one instead of adding further parameters to these
> functions?
> 
> I am asking because I am also needing to add a parameter to
> port_fdb_add(), and it would be more future oriented to have a single
> function parameter as a struct, so that it is easier to add parameters
> to these functions without havíng to change the prototype of the
> function every time.

Hi Hans

Please trim the text to only what is relevant when replying. It is
easy to miss comments when having to Page Down, Page Down, Page down,
to find comments.

   Andrew