netdev - Re: [PATCH net-next v1 1/4] net: phy: broadcom: Add PTP support for some Broadcom PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2823186c-d495-bd9b-87be-5e98a980ca04@gmail.com>
Date:   Tue, 26 Apr 2022 11:02:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Richard Cochran <richardcochran@...il.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     bcm-kernel-feedback-list@...adcom.com, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next v1 1/4] net: phy: broadcom: Add PTP support for
 some Broadcom PHYs.

On 4/25/22 19:53, Richard Cochran wrote:
> On Mon, Apr 25, 2022 at 04:55:40PM -0700, Jonathan Lemon wrote:
> 
>> We could just have a chip-specific version of this function.  The
>> recovered timestamp is passed back in a structure, so the rest of the
>> code would be unchanged.
> 
> Yeah, but it means that I'll have to check each and every bit of every
> register to see what other random changes are there...
> 
>> Jonathan    (no, not volunteering to do this...)
> 
> For now, just get your chip merged, and then the next chip's driver
> will refactor/reuse as needed.

Agreed, if we want to support Gen1 PHYs we can easily do that with 
adding a table of register offsets per family.
-- 
Florian