netdev - Re: [PATCH perf/core 3/5] perf tools: Move libbpf init in libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbfghXdt4wAmRbgRiP2_jiCkRtD+AYL+CTKKY-4OPKg6w@mail.gmail.com>
Date:   Mon, 25 Apr 2022 23:21:12 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "linux-perf-use." <linux-perf-users@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH perf/core 3/5] perf tools: Move libbpf init in libbpf_init function

On Mon, Apr 25, 2022 at 12:25 AM Jiri Olsa <olsajiri@...il.com> wrote:
>
> On Fri, Apr 22, 2022 at 02:03:24PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Apr 22, 2022 at 12:00:23PM +0200, Jiri Olsa escreveu:
> > > Moving the libbpf init code into single function,
> > > so we have single place doing that.
> >
> > Cherry picked this one, waiting for Andrii to chime in wrt the libbpf
> > changes, if its acceptable, how to proceed, i.e. in what tree to carry
> > these?
>
> I think at this point it's ok with either yours perf/core or bpf-next/master,
> I waited for them to be in sync for this ;-)

I'd rather have all the libbpf code stay in bpf-next, otherwise Github
sync process becomes very hairy. BTW, I think libbpf v0.8 release is
pretty close, I plan to add few small features before cutting it, but
that should be done pretty soon

>
> but as you pointed out there's issue with perf linked with dynamic libbpf,
> because the current version does not have the libbpf_register_prog_handler
> api that perf needs now.. also it needs the fix and api introduced in this
> patchset
>
> I'll check and perhaps we can temporirly disable perf/bpf prologue generation
> for dynamic linking..? until the libbpf release has all the needed changes
>
> jirka
>
> >
> > - Arnaldo
> >
> > > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > > ---
> > >  tools/perf/util/bpf-loader.c | 27 ++++++++++++++++++---------
> > >  1 file changed, 18 insertions(+), 9 deletions(-)
> > >

[...]