lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Apr 2022 09:50:15 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Marek BehĂșn <kabel@...nel.org>, Nathan Rossi <nathan@...hanrossi.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [PATCH] net: dsa: mv88e6xxx: Skip cmode writable for mv88e6*41 if unchanged Hello, On Sat, 2022-04-23 at 15:25 +0200, Marek BehĂșn wrote: > On Sat, 23 Apr 2022 13:20:35 +0000 > Nathan Rossi <nathan@...hanrossi.com> wrote: > > > The mv88e6341_port_set_cmode function always calls the set writable > > regardless of whether the current cmode is different from the desired > > cmode. This is problematic for specific configurations of the mv88e6341 > > and mv88e6141 (in single chip adddressing mode?) where the hidden > > registers are not accessible. > > I don't have a problem with skipping setting cmode writable if cmode is > not being changed. But hidden registers should be accessible regardless > of whether you are using single chip addressing mode or not. You need > to find why it isn't working for you, this is a bug. For the records, I read the above as requiring a fix the root cause, so I'm not applying this patch. Please correct me if I'm wrong. Thanks, Paolo
Powered by blists - more mailing lists