netdev - Re: [PATCH net-next 03/14] eth: cpsw: remove a copy of the NAPI_POLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmmwWSCLFjRIUX3J@electric-eye.fr.zoreil.com>
Date:   Wed, 27 Apr 2022 23:06:33 +0200
From:   Francois Romieu <romieu@...zoreil.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "grygorii.strashko@...com" <grygorii.strashko@...com>,
        "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "toke@...hat.com" <toke@...hat.com>,
        "chenhao288@...ilicon.com" <chenhao288@...ilicon.com>,
        "moyufeng@...wei.com" <moyufeng@...wei.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH net-next 03/14] eth: cpsw: remove a copy of the
 NAPI_POLL_WEIGHT define

Jakub Kicinski <kuba@...nel.org> :
> On Wed, 27 Apr 2022 15:47:03 +0000 Vladimir Oltean wrote:
[...]
> > Why is the weight even an argument to netif_napi_add() anyway?
> 
> Right, not sure, see the cover letter.

bea3348eef27e6044b6161fd04c3152215f96411 had to deal with different
per-driver weight values when napi_struct and netif_napi_add were
introduced back in 2007.

>From there you can almost jump back to NAPI origin when drivers
had to be converted one by one and distros did not provide udev
tooling to tweak what could had been a one-size-fits-all kernel
setting.

-- 
Ueimor