lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <002aafe5-2568-f153-b294-e9367b5b00c9@gmail.com> Date: Wed, 27 Apr 2022 15:23:13 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Michael Walle <michael@...le.cc> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v1 3/3] net: phy: micrel: add coma mode GPIO On 4/27/22 15:17, Michael Walle wrote: > Am 2022-04-28 00:12, schrieb Florian Fainelli: >> On 4/27/22 15:08, Michael Walle wrote: >>> Am 2022-04-28 00:06, schrieb Florian Fainelli: >>>> On 4/27/2022 2:44 PM, Michael Walle wrote: >>>>> The LAN8814 has a coma mode pin which puts the PHY into isolate and >>>>> power-dowm mode. Unfortunately, the mode cannot be disabled by a >>> s/dowm/down/ >>> >>>>> register. Usually, the input pin has a pull-up and connected to a GPIO >>>>> which can then be used to disable the mode. Try to get the GPIO and >>>>> deassert it. >>>> >>>> Poor choice of word, how about deep sleep, dormant, super isolate? >>> >>> Which one do you mean? Super isolate sounded like broadcom wording ;) >> >> Coma is not a great term to use IMHO. Yes Super isolate (tm) is a >> Broadcom thing, and you can come out of super isolate mode with >> register writes, so maybe not the best suggestion. > > I didn't come up with that name. It's all in the datasheets and it's > actually already used grep for "COMA_MODE" in phy/mscc. (Yes on that > one you can actually disable it with register access..). Even if > it is not a great name (which I agree), I'd use the same naming as > the datasheet and esp. the pin name. OK then, makes sense to use the datasheet name. -- Florian
Powered by blists - more mailing lists