netdev - Re: [PATCH net-next 03/28] sfc: Copy shared files needed for Siena

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmjK8Uq+rM96GRpx@d3>
Date:   Wed, 27 Apr 2022 13:47:45 +0900
From:   Benjamin Poirier <benjamin.poirier@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, pabeni@...hat.com,
        davem@...emloft.net, netdev@...r.kernel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 03/28] sfc: Copy shared files needed for Siena

On 2022-04-25 08:22 +0100, Martin Habets wrote:
> On Sat, Apr 23, 2022 at 06:50:07AM -0700, Jakub Kicinski wrote:
> > On Fri, 22 Apr 2022 15:57:43 +0100 Martin Habets wrote:
> > > From: Martin Habets <martinh@...inx.com>
> > > 
> > > No changes are done, those will be done with subsequent commits.
> > 
> > This ginormous patch does not make it thru the mail systems.
> > I'm guessing there is a (perfectly reasonable) 1MB limit somewhere.
> 
> I think the issue is with mcdi_pcol.h, which is 1.1MB of defines
> generated from the hardware databases. It has grown slowely over the
> years.
> I'll split up this patch and see if I can manually cut down mcdi_pcol.h.
> 

In this case, by using `git format-patch --find-copies-harder [...]` it
greatly reduces the size of patch 03 from 1.9M to 22K and makes the
actual changes easier to spot as well:

[...]
 .../net/ethernet/sfc/{ => siena}/bitfield.h   |   0
 drivers/net/ethernet/sfc/{ => siena}/efx.c    |   0
 drivers/net/ethernet/sfc/{ => siena}/efx.h    |   0
 .../ethernet/sfc/{ => siena}/efx_channels.c   | 148 ++++++++----------
 .../ethernet/sfc/{ => siena}/efx_channels.h   |   0
 .../net/ethernet/sfc/{ => siena}/efx_common.c |   0
 .../net/ethernet/sfc/{ => siena}/efx_common.h |   0

That being said, I don't want to discourage you from doing that rework!