netdev - Re: [PATCH] net: pass back data left in socket after receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11d08d3d-bdf8-68f8-1068-5812b6fff1f5@kernel.dk>
Date:   Thu, 28 Apr 2022 16:57:25 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Paolo Abeni <pabeni@...hat.com>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: pass back data left in socket after receive

On 4/28/22 4:37 PM, Eric Dumazet wrote:
> On Thu, Apr 28, 2022 at 3:18 PM Jakub Kicinski <kuba@...nel.org> wrote:
>>
>> On Wed, 27 Apr 2022 13:49:34 -0600 Jens Axboe wrote:
>>> This is currently done for CMSG_INQ, add an ability to do so via struct
>>> msghdr as well and have CMSG_INQ use that too. If the caller sets
>>> msghdr->msg_get_inq, then we'll pass back the hint in msghdr->msg_inq.
>>>
>>> Rearrange struct msghdr a bit so we can add this member while shrinking
>>> it at the same time. On a 64-bit build, it was 96 bytes before this
>>> change and 88 bytes afterwards.
>>>
>>> Signed-off-by: Jens Axboe <axboe@...nel.dk>
>>
>> LGTM, but I said that once before..  Eric?
> 
> For some reason I have not received this patch to my primary email address.

Huh weird. In general, email is a giant clown town these days,
unfortunately...

> This looks good, but needs to be rebased for net-next, see below ?

Thanks - yes Jakub also mentioned that to me.

> Also, maybe the title should reflect that it is really a TCP patch.

I'll send out a v2 against net-next and update the commit as well.

-- 
Jens Axboe